Solved A few bugs

[Frode]

Hi! Thank you again for this addon <3

A few stuff after playing around with the addon a bit:

1. Vote on best player count gives error:


2. Different link color for illustrator. Link does not work. (but it works for publisher and designer). Also auto-complete doesn't work for this field in add game (maybe related).

3. When clicking for rating the player counts in the "at the table" section, you can't see what you are selecting (or if it even selects anything).


4. Should this be numbered? Both are listed with a "0" before. Maybe allow voting from users with up arrow (how reviews can be rated in base XF)? Should also be a limit how many are shown (3 is probably good), for page readability. If the game suddenly has 20 house rules or common rules get wrong, what do we do? Slider bar in just that section? Arrow to quick load next section of 3 without reloading the full page?


5. Border issue/cut-off on the mechanics.


6. Not a bug per-se, but the mechanics and categories should probably be collapsible (by default closed). With 20 categories and 50 mechanics, it quickly becomes unruly


7. Rankings page is the only page not keeping the sidebar and the layout from the other Games pages. (also applies to GameHub main addon):


8. In ACP, this link is dead.


9. The scoring info table I wrote (which was added to GameHub), is not appearing here? Also, the weight information scale needs to be visible somewhere for the end user when browsing the games. 3,5/5 doesn't explain as much without the info scale.


10. Should be able to add multiple designers or publishers or illustrators. Should use base tag based system, where a comma means seperation between them. I thought it had the same here, but I ended up with this as one publisher "Fryx Games, Stronghold Games". ^^

11. When selecting expansion entry type, there is no field to link this to the base game it is connected to. All the options (expansion, stand-alone expansion, accessory, revised edition) should attach to a base game entry type. Then on the game page for that content, it says in the title area somwhere:
[Entry_type] of [base_game]. Eg. Expansion of "Terraforming Mars".

 

[Gwendal]

All eleven are done and 1.0.6 is on the store. Seven were real defects, four were things the add-on should have been doing all along. Taking them in your order.

1. Voting on best player count gave an error​

A genuine bug, and a nasty kind. The link on the game page was built from a route name that does not exist, so XenForo quietly fell back to a different route, dropped the game id on the way, and served a not found page. No error anywhere, just a dead button.

Both that link and the form it opens are fixed. I also added a build check that refuses to package a release if any link points at a route that is not declared, so this particular kind of silence cannot happen again.

2. The illustrator​

You found three separate faults with one screenshot.

• The wrong colour, because that one link was wrapped in an extra element the colour rule did not reach. Designer and publisher were not wrapped, which is why only the illustrator looked different.
• The dead link, because the search behind it only ever looked at designers and publishers. It never knew illustrators existed, so the page it opened was always empty.
• No autocomplete, for the same reason: the field had never been taught about illustrators.

All three are fixed, and illustrator credits now count on the person page alongside designed and published.

3. You cannot see what you are selecting on the player count​

Correct, and it was worse than it looked. The radio button is invisible by design and the highlight was only drawn when the server rebuilt the page, so clicking genuinely changed nothing you could see until you saved. The choice now lights up as you make it, with a fallback for older browsers.

4. The notes before you play​

The number is the vote score, and it now says so when you hover it. It read as nothing because you wrote both notes yourself, and you cannot vote on your own note, so no arrows were drawn for you. Ask someone else on your board to look at the same page and they will see the up and down arrows you were expecting, exactly like a review in XenForo.

On your other point, you were right that twenty house rules would take over the page. Each column now shows three, with a Show all link for the rest that unfolds in place, no page reload. Three is the default and it is an option, and setting it to zero shows everything as before.

5. The cut off mechanics​

Fixed. A long name now shortens with an ellipsis instead of running past the edge of the card.

6. Collapsible categories and mechanics​

Done, and closed by default as you asked. Each block shows its count in the header, and whether a member opens it is remembered on their own device, so anyone who prefers them open only has to say so once.

7. Rankings has a different layout​

It was the only page in the section without the sidebar and the two column shell. It now matches every other page.

8. The dead link in the Admin CP​

That one was embarrassing. Five buttons pointed at the video game hub instead of the board game one, left over from the two editions sharing a codebase. On a forum without GameHub installed they were simply dead. They now go where they say they go.

9. The scoring table, and the weight scale​

The scale you wrote for GameHub was in here all along, in the Admin CP, but nothing on the public side ever read it. It does now.

Your second point was the better one. A weight of 3.5 out of 5 says almost nothing on its own, so there is a second panel explaining what each level of rules complexity and strategic complexity actually means. Both panels sit on the game page, both stay closed until someone opens them, both are ordinary phrases you can reword, and there is an option to turn them off entirely.

10. Several designers, publishers or illustrators​

Now works the way you expected: type them separated by commas. Each name gets its own link, the suggestions offer one name at a time rather than the whole list you had saved, and searching for a name finds it even when it sits in the middle of someone else's list. Your existing "Fryx Games, Stronghold Games" will split into two working links on its own, nothing to re-enter.

11. No field to link an expansion to its base game​

The field existed, it just never appeared. The script was revealing the row one way and the stylesheet was hiding it another, and the stylesheet won, so nothing you selected ever opened it. Fixed for all four derived types.

Once a base game is set, the game page says which game it expands, in the header next to the entry type, as you described.

While I was in there, the copy details from the base game box from 1.0.5 now appears at the same moment, so choosing Expansion gives you both the base game field and the option to fill everything in from it.

Thank you for these. Eleven reports, no duplicates, every one with a screenshot showing exactly what you meant. That is a rarer thing than you might think, and it made the whole round quick.

 

[Frode]

Thanks for the swift fixes!